Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: additional styling to match Umbraco.BlockGrid.ExampleWebsite #73

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

kevin9092
Copy link
Contributor

Description

BlockPreview output should be as close as possible to the Angular/WebComponent equivalent.

Issue

Based off of the source repo, BlockPreview should ideally provide a 1:1 replication.

Umbraco 13 Angular View:
image

Umbraco 13 BlockPreview View:
image

Umbraco 13 BlockPreview View with Fix:
image

Note

I have also added position:relative to the .card class as this was missing from the original styling. In Umbraco.BlockGrid.Example.Website project, the card is a button element rather than a div which contains position: relative.

Fix

Applied styling to the container element .blockelement__draggable-element produced by BlockPreview to grow to the full height of the area.

.blockelement__draggable-element {
    height: 100%;
}

.blockelement__draggable-element > div {
    height: 100%;
}

This fix could potentially sit in /wwwroot/App_Plugins/Umbraco.Community.BlockPreview/views/block-preview.html, however I decided against an inline style fix as I avoid using them when possible and in the event people have worked around this in their own styling I did not want to force a change on their website styling.

@rickbutterfield
Copy link
Owner

Thank you once again @kevin9092! Appreciate the depth of your notes as well, really helpful #h5yr

@rickbutterfield rickbutterfield merged commit 0ce5b62 into rickbutterfield:v1/dev Oct 3, 2024
@rickbutterfield rickbutterfield added bug Something isn't working hacktoberfest-accepted labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants