feat(MasterFile): handle undefined type ("TYPExxx")

richardschneider · Aug 18, 2018 · a7e8327 · a7e8327
1 parent 98d2c55
commit a7e8327
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 0 deletions.
diff --git a/src/MasterReader.cs b/src/MasterReader.cs
@@ -184,6 +184,11 @@ public ResourceRecord ReadResourceRecord()
                 }
 
                 // Is TYPE?
+                if (token.StartsWith("TYPE"))
+                {
+                    type = (DnsType)ushort.Parse(token.Substring(4), CultureInfo.InvariantCulture);
+                    continue;
+                }
                 if (Enum.TryParse<DnsType>(token, out DnsType t))
                 {
                     type = t;

diff --git a/src/ResourceRecord.cs b/src/ResourceRecord.cs
@@ -318,6 +318,10 @@ public void Write(TextWriter writer)
             writer.Write(Class);
             writer.Write(' ');
 
+            if (!Enum.IsDefined(typeof(DnsType), Type))
+            {
+                writer.Write("TYPE");
+            }
             writer.Write(Type);
             writer.Write(' ');
 

diff --git a/test/MasterReaderTest.cs b/test/MasterReaderTest.cs
@@ -71,6 +71,17 @@ public void ReadResourceWithUnknownClass()
             Assert.IsInstanceOfType(resource, typeof(ARecord));
         }
 
+        [TestMethod]
+        public void ReadResourceWithUnknownType()
+        {
+            var reader = new MasterReader(new StringReader("me CH TYPE1234"));
+            var resource = reader.ReadResourceRecord();
+            Assert.AreEqual("me", resource.Name);
+            Assert.AreEqual(Class.CH, resource.Class);
+            Assert.AreEqual(1234, (int)resource.Type);
+            Assert.IsInstanceOfType(resource, typeof(UnknownRecord));
+        }
+
         [TestMethod]
         public void ReadResourceWithComment()
         {

diff --git a/test/ResourceRecordTest.cs b/test/ResourceRecordTest.cs
@@ -193,7 +193,17 @@ public void Stringing_UnknownClass()
                 Type = DnsType.A
             };
             Assert.AreEqual("x.emanon.org CLASS1234 A", a.ToString());
+        }
 
+        [TestMethod]
+        public void Stringing_UnknownType()
+        {
+            var a = new ResourceRecord
+            {
+                Name = "x.emanon.org",
+                Type = (DnsType)1234
+            };
+            Assert.AreEqual("x.emanon.org IN TYPE1234", a.ToString());
         }
     }
 }