Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Improved instruction selector loading state handling #55

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

lumpinif
Copy link
Collaborator

@lumpinif lumpinif commented Dec 3, 2024

Fix Instruction Selector Loading State

Screenshot 2024-12-03 010837

Changes Made

  • Fixed loading state visibility during initial data fetching
  • Added empty state check to prevent UI flickering
  • Enhanced state transitions between loading and loaded states

Testing

  • Verified loading indicator appears when data is being fetched
  • Confirmed smooth transition from loading to loaded state
  • Tested edge cases with empty instruction sets

Screenshots

Before: Loading state was not visible during data fetching
After: Loading state properly shows until data is fully loaded

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changelog

Added in CHANGELOG.md under 12/3/2024

@richards199999 richards199999 merged commit 30dd539 into richards199999:main Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants