Standardize test assertions for sample files #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test_com_allsamples test is the only one that's using self.fail() instead of functions from the unittest.UnitTest class. Because of this, failures show a super obscure output that does not show the actual nature of the failure, which makes it really difficult to debug. With self.assert*() at least when there is a difference in values, it will get shown, leading to easier debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_com_allsamplestest is the only one that's using self.fail() instead of functions from the unittest.UnitTest class. Because of this, failures show a super obscure output that does not show the actual nature of the failure, which makes it really difficult to debug.With
self.assert*()at least when there is a difference in values, it will get shown, leading to easier debugging.