Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "before YYYY" entries #230

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

BillWeissABK
Copy link
Contributor

@BillWeissABK BillWeissABK commented Jun 17, 2024

Pretty trivial change, but it seems to work :)
Fixes #228

Before:

>>> import whois
>>> whois.whois("ns.tomis.ro")
{'domain_name': 'tomis.ro', 'domain_status': 'OK', 'registrar': 'ICI - Registrar', 'referral_url': 'http://www.rotld.ro', 'creation_date': 'Before 2001', 'expiration_date': datetime.datetime(2028, 5, 29, 0, 0), 'name_servers': ['ns1.lucaservices.ro', 'ns2.lucaservices.ro'], 'status': 'OK', 'dnssec': 'Inactive'}

After:

>>> import whois
>>> whois.whois("ns.tomis.ro")
{'domain_name': 'tomis.ro', 'domain_status': 'OK', 'registrar': 'ICI - Registrar', 'referral_url': 'http://www.rotld.ro', 'creation_date': datetime.datetime(2001, 1, 1, 0, 0), 'expiration_date': datetime.datetime(2028, 5, 29, 0, 0), 'name_servers': ['ns1.lucaservices.ro', 'ns2.lucaservices.ro'], 'status': 'OK', 'dnssec': 'Inactive'}

@BillWeissABK BillWeissABK changed the title Handle "before YYYY" entries to fix #228 Handle "before YYYY" entries Jun 17, 2024
@richardpenman
Copy link
Owner

Thanks for all the fixes Bill!

@richardpenman richardpenman reopened this Jun 17, 2024
@richardpenman richardpenman merged commit 388f083 into richardpenman:master Jun 17, 2024
6 checks passed
@BillWeissABK BillWeissABK deleted the fix-issue-228 branch June 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling invalid creation_date format for some domains
2 participants