forked from Azure/azure-sdk-for-js
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docs for App Configuration #1
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpark-msft
force-pushed
the
adding_docs
branch
2 times, most recently
from
September 4, 2019 19:17
1b49586
to
423904a
Compare
richardpark-msft
changed the title
Adding docs for AppConfig
Adding docs for App Configuration
Sep 4, 2019
chradek
reviewed
Sep 4, 2019
richardpark-msft
commented
Sep 4, 2019
richardpark-msft
force-pushed
the
adding_docs
branch
2 times, most recently
from
September 4, 2019 22:52
758e621
to
1d2ab06
Compare
ramya-rao-a
reviewed
Sep 5, 2019
ramya-rao-a
reviewed
Sep 5, 2019
ramya-rao-a
reviewed
Sep 5, 2019
ramya-rao-a
reviewed
Sep 5, 2019
ramya-rao-a
reviewed
Sep 5, 2019
richardpark-msft
force-pushed
the
adding_docs
branch
from
September 5, 2019 16:04
9355aa3
to
c3f8139
Compare
richardpark-msft
force-pushed
the
adding_docs
branch
from
September 5, 2019 16:07
c3f8139
to
9f9cbc4
Compare
richardpark-msft
pushed a commit
that referenced
this pull request
Jan 31, 2020
* [MQ Goals] ARM template for Storage Blob If the ARM template works (tests-resources.json), then it will be the same for each of the storage clients. tests.yml should be almost the same for the other storage clients, with some of the content changed, reflecting the appropriate name of the client. * feedback * wrong path here * all of the tests.yml for storage * fixed the paths * added provisionerTenantId * using ../archetype-sdk-tests-storage.yml again * optimization on the env variables * optimizations on ResourceFileLocation * lowercase string * variables('storageApiVersion') * tenantId resources shouldnt be necessary * removed provisionerTenantId and uppercased the env variables * moved the ARM specific parameters to variables * this is closer to work * update * storage-blob updated tests.yml * seems like the archetype file needed to change * seems like the template is invalid somehow. Trying this * tweaks, to see if things change * this should work now * ResourceServiceDirectory can be optimized * add AAD secret references in the ENV vars for the resource creation - arm-template #RequiredForCI * run a single test * DEBUG #1 * reduce matrix * only keep the samples in the pipeline * print all * keep test job too - Linux_Node10 * last resort - move around EnvVars * remove duplication * update ResourceServiceDirectory as per Daniel's suggestion * ResourceServiceDirectory: storage * ResourceServiceDirectory: ${{ parameters.ResourceServiceDirectory }} * Update sdk/storage/test-resources.json * Update sdk/storage/test-resources.json * Update sdk/storage/test-resources.json * remove .only * remove env from imports * add blob contributor role to the AAD service principal * add "apiVersion": "[variables('authorizationApiVersion')]", * add "authorizationApiVersion": "2017-05-01", * 2018-01-01-preview - authorizationApiVersion * add more sas permissions * revert the matrix back to full * simplified CORS rules * smaller matrix to reduce the load * formatting changes * nested resources * add cors rules for file and queue as well * queueServices unsupported with CORS * revert matrix back to full * revert archetype-sdk-tests-storage.yml * update tests.yml for storage-blob and file-share to the new format * revert unintended change * revert changes to archetype-storage . yml Co-authored-by: Daniel Rodríguez <[email protected]>
richardpark-msft
added a commit
that referenced
this pull request
Feb 19, 2021
…calCode.OK (0) but now is StatusCode.OK (1)).
richardpark-msft
added a commit
that referenced
this pull request
Feb 19, 2021
…calCode.OK (0) but now is StatusCode.OK (1)).
richardpark-msft
added a commit
that referenced
this pull request
Feb 22, 2021
…afterwards, however) (Azure#13881) (NOTE: CI is still broken as we have to investigate the rest of the breakages in the test) * Problem #1 - the underlying value has changed (it used to be a CanonicalCode.OK (0) but now is StatusCode.OK (1)). * Fixing issue where the test failing wasn't actually passed on to the test framework.
richardpark-msft
added a commit
that referenced
this pull request
Mar 11, 2021
…hanges with the latest opentelemetry: - CanonicalCode is now SpanStatusCode - span propagation uses some new functions (set|get)spanContext, (set|get)Span. This isn't used directly in client code but the opentelemetry is a bit of a leaky abstraction right now
richardpark-msft
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Update maps dependency in pnpm-lock.yaml * Fix sample metadata errors * Fix linting errors * Fix linting errors * Fix run time error * Update package.json in samples folder * Fix linting errors * Fix linting errors * Add changelog for maps-common * Update recording files for maps-search * Add test.yml for maps-search * Add tests.yml for render and route * Update tests.yml * Update test-resources.json for maps * Fix tests.yml format error * Update env vars and remove unused export var * Remove unused code * Fix lock file * Remove route & render * Replace `beginGet*Batch` with `resume*Batch` We provide a `beginGet*Batch` method to resume the previous request previously. This is not ideal because it need to get a `batchId` which is store in the internal state of the LRO. Once the LRO brings changes, our code will be broken. We can achieve the same thing by using serialized state. This change aims to leverage this approach and create convenience methods `resume*Batch` for users * Update recording * Make the endpoint of `MapsSearchClient` configurable * Change LatLon from an interface to a tuple Also remove the `toLatLon` function since creating a tuple is quite easy. * Make the props `coordinates` and `countryCodeFilter` optional Specifying `coordinates` and `countryCodeFilter` can narrow the results of the fuzzy search. But considring the case like searching "Australia", theese fields may have no use. We decided to make them optional so user can decides if they want to narrow down the results or not. * fixup! Remove route & render * Adjust CHANGELOGs of maps-search & common Following the keyvault-common, removing CHANGELOGs from maps-common since it's not published. * Update samples * Add batchRequest sample * Add a new sample searchAddressResult * Update search.ts and its examples * enhance code example in README.md * comment unused import * Update recording for maps-search * remove redundant recording files * Add maps-search * Rename LatLong to LatLon * Fix constructor Readme doc * Update readme to new signature * Add tests partially * Change LatLon/BoundingBox to interfaces * Reduce the number of constructor overloading * Rename SearchClient as MapsSearchClient * Add options mapper tests * Add result type mapper tests (in progress) * rename clientId to mapsAccountClientId * listPolygons -> getPolygons * getPointOfInterestCategoryTree -> getPointOfInterestCategories * Expose missing model * Add alternative input file for quick experiment * Regenerate code and make changes accordingly * Reduce number of overloads of fuzzy searches * Add geojson types * Adopting new geojson definitions * Change test specs to align with new method names * clean up models and tsconfig * Expose Known* models * Remove batch sync methods * Add public tests (non-batch) * move model * Add docstrings * Start polling in begin* method * Refactor BatchPoller for retrieving batchId * Finalize batch pollers * Readd batch methods * Update generated code * Finalize batch signature * Rebuild samples & clean up * Add AAD tests * Clean up Swagger readme * Fix spelling * Add initial files for @azure/maps-route module * maps-search: change comments and perform formatting * Methods options and testing skeleton for maps-route * maps-search: refactor options * Improve convenience layer for non-LRO methods * Change variable names * Complete batch methods * update maps-search Readme * Update maps-route Readme * Add generated samples for maps-route * Update samples for maps-search * Delete backup file * Add maps-common module * Update maps-route/maps-search to use maps-common * maps-render: first draft * Use LatLon/BoundingBox from maps-common * Complete maps-render with tests * Expose required types from maps-route * Expose required types from maps-search * Complete unit tests for maps-render * Update maps-render README * Update samples * Fix comment/strings * Fix comment/strings * Update Route comment/interface * Regenerate code * Update files * Define required fields and fix code * Remove non-poller batch methods * Fix playback test failure * Rename parts of model names * Rename remaining parts of models according to review feedback * Remove TODO comments * Update Reamdme transform to reflect latest swagger * Change key policy name * Simplify batch item error model * Add brower tests * Turn maps-common into internal module * Rearrange Readme * Rewrite Readme for common * Remove batch-sync methods * Route required fields: part 1 * Route required fields: part 2 * Add AAD back * Route model fixes #1 * Route model fixes #2 + geojson named tuples * Refine geojson types * Aliased a few method options * maps-render required fields part 1 * Do not validate budget parameters * Revert "Do not validate budget parameters" This reverts commit 4ec3f5f. * Rename MapTileset to TileJson * Render: model rename & type improvement * Explicitly transform image range * Fix route record tests * Update map account creation commands in Readme * Update Readme/docstrings/samples for Search/Route/Render * Remove rollup and use dev-tool instead * Remove some empty tests * Add AAD test case and make file name shorter * Update test cases * Update cspell rules * Update recording files * Simplify test cases * Sync cspell.json from upstream * Use test-recorder 2.0 and update unit test cases * Push wrong browsers recording files * Update settings to support recording * Fix dependency errors * Upgrade api-recorder and fix errors * Code refinement * Update maps search recording files * Update karma.conf.js format * Update recording files and settings * Fix broken links * Update maps dependency in pnpm-lock.yaml * Fix sample metadata errors * Fix linting errors * Fix linting errors * Fix run time error * Update package.json in samples folder * Fix linting errors * Fix linting errors * Add changelog for maps-common * Update recording files for maps-search * Add test.yml for maps-search * Add tests.yml for render and route * Update tests.yml * Update test-resources.json for maps * Fix tests.yml format error * Update env vars and remove unused export var * Remove unused code * Fix lock file * Remove maps-render * fixup! Change LatLon from an interface to a tuple * Comment the future doc link * Update doc & fix type issue * fix lint issues * Regenerate API View * Comment the whole [apiref] since the original syntax cannot pass the Analyze/Link verification * Fix issue related to the change of maps-common - Replace beginGet*Result with resume* methods - Turn LatLon to a tuple - Add mapper to transform the string to Date because resume* method will return a serialized Date * Update test recording * Remove maps-common from the Artifacts * remove unused dependencies * Add impression in README so we can track the page views * Remove `AZURE_LOG_LEVEL` in test.yml * Update samples - Move the option parameter to the right place - Add comments & "break" for handling the type of the search result to make it clear for the user * Patch {} to properties for GeoJsonPolygon * rename maxDetourTime to maxDetourTimeInSeconds * Update recordings * Remove any * Rename to detourTimeInSeconds to align the convention * Change the test.yml EnvVar See more explanation here: - Azure#23039 (comment) - Azure#23039 (comment) * Rename numResults to numberResults * Add document comment * Add endpoint options to MapsRouteClient * Remove unused dependencies in maps-route * fixup! Change the test.yml EnvVar * Update interfaces & documents * Update changelog * Merge getRouteDirection with the additional parameter one * Update samples * Make the `maps-common to a published package * Update the import of `maps-common` in `maps-search` * Fix CI Issue * Add documents for geojson * Update the samples & readme * Leverage maps-common package in mpas-route * chore update - Remove the unnecessary rule setting of eslint - Update the legacy type path * Remove unnecessary eslint config * WIP: Remove LRO generation * WIP: refactor mapsRouteClient * WIP: first generation * Format the generated code * Support AAD * Transform the model name * Add helper functions * Add a sample - route.ts * Add samples for lro * Add test * Generate samples * Add api view * Update the generation * WIP: ReadMe * Rename "computeBestOrder" to "computeBestWaypointOrder" * Refine README * Rename model * Add test createRouteDirectionsBatchRequest * Fix lint issue * Add missing metadata * Remove maps-route/ * Update CI issue * Fix merged issue * Update version rule for maps-common * Update CI name * Remove extra lint config * Use `require` in the README for consistency * Regenerate the samples * Remove redundant recording files * Remove unused parameters in test-resources.json * Refine readme snippet * Log something specific for the result * Update samples * Split the route.ts into 3 * Remove model rename * Use default export for RLC factory function Co-authored-by: Charlie Chen <[email protected]> Co-authored-by: Charlie Chen <[email protected]> Co-authored-by: --global <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.