Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl implementation not working on osx and windows #176

Open
littleskunk opened this issue Mar 1, 2016 · 2 comments
Open

openssl implementation not working on osx and windows #176

littleskunk opened this issue Mar 1, 2016 · 2 comments

Comments

@littleskunk
Copy link
Contributor

https://github.com/richardkiss/pycoin/blob/master/pycoin/ecdsa/native/library.py#L21

This line will only work for linux and doesn't support windows and osx and it should throw a exception if the env variable is set but the library can't be loaded. At the moment i set the env variable and i get no feedback.

I would prefer this implementation:
https://github.com/uwdata/termite-stm/blob/master/web2py/gluon/contrib/pbkdf2_ctypes.py#L122

Tested on windows. I will create a pull request later.

@littleskunk
Copy link
Contributor Author

Added windows and osx support. I did not add a exception message. I think it is needed but that is your decision.

@recmo
Copy link

recmo commented Nov 17, 2016

This line will also fail in the official Python docker image python:3.6-alpine. (See issue).

The implementation of find_library is a hack. It calls ldconfig -p and parses the output, hoping that the library is in the cache. As a fallback it calls gcc to find the library. This is obviously very fragile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants