new world map visualiser #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the huge amount of time it took me to look at this -- teaching is such a nightmare. The map looks nicer but for me the request gives inaccurate results. At least for me (from UK) in the new version this is broken - it sends two straight lines from the UK to NA then another back to Japan. In the older version these are curved lines (great circles) from UK to NA then on to Japan. So the big issues (for me) are
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the world map plot made using matplotlib with a geoplot using plotly. The end result is an image (which I believe to be...) that is visually more satisfactory. The image is saved as an html plot, and can be viewed directly in the browser.