fix(plugin): actually prevent useless re-renders

ricewind012 · Feb 6, 2025 · 4c3ffb3 · 4c3ffb3
1 parent dede112
commit 4c3ffb3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/frontend/index.tsx b/frontend/index.tsx
@@ -101,11 +101,8 @@ async function AddSuperNavEvents(popup: SteamPopup) {
 	const sel = classes.supernav.Selected;
 	const observer = new MutationObserver(() => {
 		const children = [...container.children];
-		if (children.some((e) => e.classList.contains(classes.menu.MenuOpen))) {
-			return;
-		}
-
 		const tab = children.findIndex((e) => e.classList.contains(sel));
+
 		// Account for the browser navigation arrows
 		DispatchTabChange(tab - 2);
 	});

diff --git a/frontend/parts/steamdesktop/index.tsx b/frontend/parts/steamdesktop/index.tsx
@@ -11,6 +11,7 @@ import {
 	ESuperNavTab,
 	GetESuperNavTabFromSetting,
 	TAB_CHANGE_EVENT_NAME,
+	TabChangeEvent,
 } from "../../events/tabchange";
 import {
 	type GameListChangeEvent,
@@ -166,8 +167,13 @@ export class SteamDesktop extends PartComponentBase<SteamDesktopState> {
 		MainWindowBrowserManager.m_browser.Reload();
 	}
 
-	OnWindowEvent(ev: CustomEventInit<GameListChangeEvent>) {
+	OnWindowEvent(ev: CustomEventInit<GameListChangeEvent & TabChangeEvent>) {
 		const { appid, tab } = this.state;
+		if (appid === ev.detail.appid || tab === ev.detail.tab) {
+			return;
+		}
+
+		console.warn("EVENT", this.state, ev.detail);
 		this.setState({ appid, tab, ...ev.detail });
 	}