Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: performance optimizations #281

Merged
merged 31 commits into from
Jun 13, 2022
Merged

perf: performance optimizations #281

merged 31 commits into from
Jun 13, 2022

Conversation

riccardoperra
Copy link
Owner

@riccardoperra riccardoperra commented Jun 11, 2022 •
edited
Loading

Issue Number: #264

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 3eb45f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@codeimage/config Major
@codeimage/highlight Minor
@codeimage/app Minor
@codeimage/locale Minor
@codeimage/ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
codeimage ✅ Ready (Inspect) Visit Preview Jun 12, 2022 at 9:51PM (UTC)

@vercel vercel bot temporarily deployed to Preview June 11, 2022 14:23 Inactive
@riccardoperra riccardoperra changed the title Performance optimizations perf: performance optimizations Jun 11, 2022
@vercel vercel bot temporarily deployed to Preview June 11, 2022 14:29 Inactive
@riccardoperra riccardoperra force-pushed the performance_optimizations branch from 177a874 to 29c58e7 Compare June 11, 2022 14:45
@vercel vercel bot temporarily deployed to Preview June 11, 2022 15:10 Inactive
@riccardoperra riccardoperra force-pushed the performance_optimizations branch from 82dd0c5 to e17172c Compare June 11, 2022 15:19
@vercel vercel bot temporarily deployed to Preview June 11, 2022 15:20 Inactive
@riccardoperra
Copy link
Owner Author

Before

  • app.js: 628.36KiB / gzip: 194.21KiB

Now
image

@riccardoperra
Merge pull request #282 from riccardoperra/perf/inline_combobox_lazy
35bc860 
perf: add lazy loading w/ suspense to InlineCombobox
@riccardoperra riccardoperra force-pushed the performance_optimizations branch from e17172c to 35bc860 Compare June 11, 2022 15:24
@vercel vercel bot temporarily deployed to Preview June 11, 2022 15:25 Inactive
@riccardoperra riccardoperra force-pushed the performance_optimizations branch from 6acf24b to 436b21d Compare June 12, 2022 19:10
@vercel vercel bot temporarily deployed to Preview June 12, 2022 19:11 Inactive
@vercel vercel bot temporarily deployed to Preview June 12, 2022 19:25 Inactive
@vercel vercel bot temporarily deployed to Preview June 12, 2022 20:35 Inactive
@riccardoperra riccardoperra force-pushed the performance_optimizations branch from fa36f24 to 675e718 Compare June 12, 2022 21:03
@vercel vercel bot temporarily deployed to Preview June 12, 2022 21:05 Inactive
@riccardoperra riccardoperra force-pushed the performance_optimizations branch from ed82389 to 18c1e22 Compare June 12, 2022 21:06
@vercel vercel bot temporarily deployed to Preview June 12, 2022 21:07 Inactive
@vercel vercel bot temporarily deployed to Preview June 12, 2022 21:21 Inactive
@vercel vercel bot temporarily deployed to Preview June 12, 2022 21:24 Inactive
@riccardoperra riccardoperra force-pushed the performance_optimizations branch from 4f31931 to e070858 Compare June 12, 2022 21:27
@vercel vercel bot temporarily deployed to Preview June 12, 2022 21:29 Inactive
@riccardoperra riccardoperra force-pushed the performance_optimizations branch from e070858 to 8c24cec Compare June 12, 2022 21:39
@vercel vercel bot temporarily deployed to Preview June 12, 2022 21:40 Inactive
@riccardoperra riccardoperra force-pushed the performance_optimizations branch from 8c24cec to 3eb45f0 Compare June 12, 2022 21:50
@riccardoperra
Copy link
Owner Author

image

@vercel vercel bot temporarily deployed to Preview June 12, 2022 21:51 Inactive
@riccardoperra
Copy link
Owner Author

riccardoperra commented Jun 12, 2022 •
edited
Loading

After

image
image

@riccardoperra
Copy link
Owner Author

Before

image

image

riccardoperra
riccardoperra commented Jun 12, 2022
View reviewed changes
packages/config/src/lib/base/themes.ts Outdated Show resolved Hide resolved
packages/highlight/src/lib/core/build-theme.ts Outdated Show resolved Hide resolved
packages/highlight/src/lib/core/custom-theme.ts Outdated Show resolved Hide resolved
@riccardoperra
Copy link
Owner Author

image
https://googlechrome.github.io/lighthouse-ci/viewer/

@riccardoperra riccardoperra merged commit 046bac2 into main Jun 13, 2022
@riccardoperra riccardoperra deleted the performance_optimizations branch June 13, 2022 10:45
@github-actions github-actions bot mentioned this pull request Jun 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@riccardoperra