Adding support for Maven with GAR #111
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 371b2a3.
Comment on lines
+4
to
+11
| - run: | ||
| name: install gcloud | ||
| command: | | ||
| curl https://sdk.cloud.google.com > install.sh | ||
| bash install.sh --disable-prompts | ||
| export PATH=/home/circleci/google-cloud-sdk/bin/:${PATH} | ||
| gcloud components install kubectl | ||
| echo 'export PATH=/home/circleci/google-cloud-sdk/bin/:${PATH}' >> $BASH_ENV |
There was a problem hiding this comment.
what is the runtime for this? 😟
There was a problem hiding this comment.
Hehe yep, I had the same worry... what we agreed with @robert-nemet was to first make it work, and then see how to optimize it.
IIRC the idea would be to have an executor that has the tooling already installed.
There was a problem hiding this comment.
my experience 20 months ago was
- pulling a custom executor image adds 1min to your build
- installing gcloud stuff adds >1min to your build
so either way im kinda worried, unless its an image replacing a custom image (in which case the additional time was already a reality)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/smgnet/From-JFrog-to-GAR-169a151798304c70a12792443379db55?pvs=4