Js monorepo #103
Open
Js monorepo #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-may
requested changes
Oct 26, 2023
| @@ -13,11 +13,13 @@ steps: | |||
| - checkout | |||
| - run: | |||
| name: Install dependencies | |||
| command: yarn --immutable | |||
| command: | | |||
There was a problem hiding this comment.
i think it would be cleaner to have a parameter called: working_directory and then before the steps set:
working_directory: ~/project/<< parameters.working_directory >>
this allows you to not take care of the paths everywhere but set once and let the rest as it was before
Comment on lines
9
to
15
| - when: | ||
| condition: | ||
| equal: [ true, << parameters.do_checkout >> ] | ||
| steps: | ||
| # in auth0 build files are committed | ||
| - checkout | ||
| - checkout |
There was a problem hiding this comment.
to me this looks like checking out with an extra step :) what do you want to achieve?
added 2 commits
October 27, 2023 15:43
julien-may
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add monorepo support for some js jobs:
js_install_dependencies_job.yml- solves issue of not having ci config in the app rootjs_yarn_runner_job.yml- same as abovejs_push_build_to_bucket_job.yml- in auth0, for now build files are versioned, so wee need to checkout before pushing assets