Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small error handling improvements #27

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Small error handling improvements #27

merged 2 commits into from
Jun 9, 2023

Conversation

EtienneGuerlais
Copy link
Contributor

@EtienneGuerlais EtienneGuerlais commented Jun 8, 2023 •
edited
Loading

  • Remove all references to the deprecated pkg/errors library
  • Fix the error stacktrace logging
  • Improve error comparison for ErrEventUnretriable and ErrEventOmitted
  • Build using go 1.20 instead of 1.19 to allow the multiple %w syntax I'm using in the tests (no expected impact on the rest of the library)

@EtienneGuerlais EtienneGuerlais requested review from gplume and ErwanVP June 8, 2023 11:00
gplume
gplume reviewed Jun 8, 2023
View reviewed changes
listener.go Show resolved Hide resolved
gplume
gplume reviewed Jun 8, 2023
View reviewed changes
listener_test.go Outdated Show resolved Hide resolved
@EtienneGuerlais EtienneGuerlais marked this pull request as ready for review June 8, 2023 15:45
gplume
gplume approved these changes Jun 9, 2023
View reviewed changes
Copy link

@gplume gplume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now, thanks! 👍

@EtienneGuerlais EtienneGuerlais merged commit e9a1b9d into master Jun 9, 2023
@EtienneGuerlais EtienneGuerlais deleted the errorhandling branch June 9, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gplume gplume gplume approved these changes

@ErwanVP ErwanVP Awaiting requested review from ErwanVP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EtienneGuerlais @gplume