Do not use remote style guides #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like Hound can't cope with remote style guides. See: houndci/hound#996
|
Thanks @skalee for making it work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3.
Looks like my previous observations were wrong, and Hound does not support style guide inheritance from remote URLs. Maybe I've looked at some stale Hound comment (I was changing guide several times), or simply overlooked something, I don't know. The fact is that we can't inherit style guides from remote URLs. Hound maintainers have their reasons for that: houndci/hound#996.
The simplest solution is to keep the style guides locally. Only the Thoughtbot's guide is expected to be updated frequently, hence there shouldn't be much hassle. However, we may try out Hound's style guides for organizations to make it all easier.
FYI @ribose-jeffreylau @ronaldtse @abunashir.