Removed user_id from config #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to store user_id in the configuration file because we can read from controller and modify only one byte. Storing in a configuration file may also cause some issues when someone incorrectly set the byte responsible for the ability to move the desk. I also noticed that BASE_HEIGHT offset is different for my desk so I added a read from the controller to be fully synchronized.
Closed
Tested without server
kaml123
force-pushed
the
dpg1c_support
branch
from
63fdbc0 to
6f87814
Compare
|
Thank you! How do you know that the first byte of the user id must be |
|
I tested this on my DPG1C and setting this byte to 1 solve the issue. I can write any values to the rest of bytes but first byte must be 1 to be able to move desk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to store user_id in the configuration file because we can read from controller and modify only one byte. Storing in a configuration file may also cause some issues when someone incorrectly set the byte responsible for the ability to move the desk.
I also noticed that BASE_HEIGHT offset is different for my desk so I added a read from the controller to be fully synchronized.