Skip to content

Commit

Permalink
update typescript-eslint to fix type error on passing other plugin to…
Browse files Browse the repository at this point in the history
… `ts.config()`
  • Loading branch information
rhysd committed Aug 20, 2024
1 parent 7a1e09d commit 326d7d7
Show file tree
Hide file tree
Showing 3 changed files with 93 additions and 91 deletions.
6 changes: 0 additions & 6 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@ import n from 'eslint-plugin-n';
export default ts.config(
eslint.configs.recommended,
...ts.configs.recommendedTypeChecked,
// @ts-expect-error Types of typescript-eslint is not compatible with @types/eslint.
// These packages provide their own types for eslint.config.mjs and they are not compatible with each other.
// eslint-plugin-n uses @types/eslint but `ts.config()` does not accept the flat config of the plugin.
// The maintainer of typescript-eslint won't improve this situation. So ignoring type error here is the best
// we can do.
// See https://github.com/typescript-eslint/typescript-eslint/issues/8613#issuecomment-1983488262
n.configs['flat/recommended'],
{
languageOptions: {
Expand Down
170 changes: 89 additions & 81 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,18 +57,18 @@
"@types/eslint-plugin-mocha": "^10.4.0",
"@types/mocha": "^10.0.7",
"@types/mock-require": "^2.0.3",
"@types/node": "^22.1.0",
"@types/node": "^22.4.1",
"@types/node-fetch": "^2.6.11",
"concurrently": "^8.2.2",
"eslint": "^9.8.0",
"eslint": "^9.9.0",
"eslint-plugin-mocha": "^10.5.0",
"eslint-plugin-n": "^17.10.2",
"husky": "^9.1.4",
"mocha": "^10.7.0",
"mocha": "^10.7.3",
"mock-require": "^3.0.3",
"nyc": "^17.0.0",
"prettier": "^3.3.3",
"typescript": "^5.5.4",
"typescript-eslint": "^8.0.0"
"typescript-eslint": "^8.2.0"
}
}

0 comments on commit 326d7d7

Please sign in to comment.