Use WordPress constant to load Predis library #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified object cache to use WP_CONTENT_DIR instead 'dirname( __FILE__)'. This fixes an issue where the object cache couldn't find the Predis library. The cause was the fact that 'object-cache.php' was symlinked into 'wp-content'. 'dirname( __FILE__)' would resolve to the wrong location.
|
Just as note, I also tested |
|
+1 This is vital for our usage. |
|
Would it make sense to check |
|
I can't think of another edge case right now that isn't covered by the |
tillkruss
added a commit
that referenced
this pull request
Oct 29, 2015
Include Predis with `WP_CONTENT_DIR` instead of `dirname(__FILE__)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified object cache to use
WP_CONTENT_DIRinsteaddirname( __FILE__). This fixes an issue where the object cache couldn't find the Predis library. The cause was the fact thatobject-cache.phpwas symlinked intowp-content.dirname( __FILE__)would resolve to the wrong location.