fix: remove SeccompProfile #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that built-in SCCs (except `privileged`) don't allow to set the seccomp profile [1]. Until this is fixed in OpenShift, we shouldn't try to set `seccompProfile` (the container runtime should already use `RuntimeDefault`). [1] openshift/cluster-kube-apiserver-operator#1325 Signed-off-by: Simon Pasquier <[email protected]>
JoaoBraveCoding
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that built-in SCCs (except
privileged) don't allow to set theseccomp profile [1]. Until this is fixed in OpenShift, we should leave
it to the default (which is already
RuntimeDefault).[1] openshift/cluster-kube-apiserver-operator#1325
Fixes #163