Add check to dns resolution to container test #1353
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-os-variants |
cgwalters
reviewed
Jan 10, 2025
| @@ -20,6 +20,15 @@ reboot | |||
|
|
|||
| %post | |||
|
|
|||
| curl fedoraproject.org | |||
There was a problem hiding this comment.
That's not a URL so curl is probably going to always error. Obviously you could use https:// in front to fix that, but since the goal is to test (just) DNS using e.g. getent hosts fedoraproject.org is more direct.
There was a problem hiding this comment.
Thank you, I'll update the tests.
It seems though that it fails only on rhel10 (rhel9 and rawhide seems to pass): https://github.com/rhinstaller/kickstart-tests/actions/runs/12709561536
There was a problem hiding this comment.
On fedora there is systemd-resolved though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft PR to check the current status.
The real check would go to a separate test.
Related: #1352