Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network static tests for NM change (gh1349) #1350

Conversation

rvykydal
Copy link
Contributor

NM now dumps ipv4 address setting value into two separate 'address1' and 'gateway' keys by default.
NetworkManager/NetworkManager@38dca2f

Fixes: #1349

@rvykydal
Copy link
Contributor Author

/test-os-variants

@rvykydal rvykydal force-pushed the update-network-static-to-nm-keyfile-change branch from 7e4ac90 to 1cfca89 Compare January 10, 2025 08:49
@rvykydal
Copy link
Contributor Author

/test-os-variants

@rvykydal rvykydal force-pushed the update-network-static-to-nm-keyfile-change branch from 1cfca89 to 0246676 Compare January 10, 2025 09:36
@rvykydal
Copy link
Contributor Author

/test-os-variants

@rvykydal
Copy link
Contributor Author

rvykydal commented Jan 10, 2025

For now /test-os-variants passes only on rhel10. Let's wait with merge until the new NM propagates also to other variants (and the tests pass).

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

@rvykydal rvykydal added the blocked This can't be merged before dependencies! label Jan 14, 2025
Updated NM is now present on all tested variants.
@rvykydal rvykydal force-pushed the update-network-static-to-nm-keyfile-change branch from 0246676 to cde72d9 Compare January 22, 2025 07:54
@rvykydal
Copy link
Contributor Author

/test-os-variants

@rvykydal
Copy link
Contributor Author

/test-tmt

@rvykydal rvykydal removed the blocked This can't be merged before dependencies! label Jan 22, 2025
@rvykydal rvykydal merged commit 523470d into rhinstaller:master Jan 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

network static tests failing due to NM default profile update with "*** Failed check: IPADDR=10.0.2.200 ..."
2 participants