Use centos 10 in place of rhel 10 temporarily for rhel10 --platform #1173

rvykydal · 2024-05-16T07:14:13Z

The main reason is making /test-os-variants usable for PRs on tests.
It will affect also daily runs, but actually it will be nice to see results of all tests on centos 10 image. We can switch it back to rhel 10 later by updating the GH workflow.

rvykydal · 2024-05-16T07:14:53Z

/test-os-variants

rvykydal · 2024-05-16T07:39:21Z

The failure of rhel10 os-variant failed because the correct iso was not fetched (or rather the rawhide iso was used):

2024-05-16T07:15:10.7597148Z INFO:libpermian.plugins.kickstart_test(Thread-5):Created url overrides file /tmp/defaults-ai7sji6a with content:
2024-05-16T07:15:10.7598711Z export KSTEST_URL=https://composes.stream.centos.org/stream-10/development/latest-CentOS-Stream/compose/BaseOS/x86_64/os/
2024-05-16T07:15:10.7600470Z export KSTEST_MODULAR_URL=https://composes.stream.centos.org/stream-10/development/latest-CentOS-Stream/compose/AppStream/x86_64/os/
2024-05-16T07:15:10.7603613Z INFO:libpermian.plugins.kickstart_test(Thread-5):Using existing kickstart-tests repository /home/github/actions-runner/_work/kickstart-tests/kickstart-tests/kickstart-tests.
2024-05-16T07:15:10.7605510Z INFO:libpermian.plugins.kickstart_test(Thread-5):Fetchig installer boot.iso https://composes.stream.centos.org/stream-10/development/latest-CentOS-Stream/compose/BaseOS/x86_64/os/images/boot.iso
2024-05-16T07:15:10.7615949Z INFO:libpermian.plugins.kickstart_test(Thread-5):Runner is starting. SUCCESS: 0 FAILED: 0 N/A: 2 (runs: 0 flakes: 0 timed out: 0)
2024-05-16T07:15:10.7618145Z INFO:libpermian.plugins.kickstart_test(Thread-5):Running ['containers/runner/launch', '--scenario', 'run_subset', '--platform', 'rhel10', '--defaults', '/tmp/defaults-ai7sji6a', '--timeout', '0', 'ui_text_interactive', 'ui_graphical_interactive']
2024-05-16T07:15:10.7748712Z INFO:libpermian.plugins.kickstart_test(Thread-5):[runner] INFO: data/images/boot.iso does not exist, downloading current Fedora Rawhide Everything image...

Also the values for substitutions NAME="centos" (@KSTEST_OS_NAME@) in tested kickstart are not those that would be expected for rhel 10, for example here:

kickstart-tests/dns.ks.in

Line 16 in cdce5e6

if [ "@KSTEST_OS_NAME@" == "rhel" ]; then

+++ NAME='CentOS Stream'
+++ VERSION=10
+++ ID=centos
+++ ID_LIKE='rhel fedora'
+++ VERSION_ID=10
+++ PLATFORM_ID=platform:el10
+++ PRETTY_NAME='CentOS Stream 10'
+++ ANSI_COLOR='0;31'
+++ LOGO=fedora-logo-icon
+++ CPE_NAME=cpe:/o:centos:centos:10
+++ HOME_URL=https://centos.org/
+++ BUG_REPORT_URL=https://issues.redhat.com/
+++ REDHAT_SUPPORT_PRODUCT='Red Hat Enterprise Linux 10'
+++ REDHAT_SUPPORT_PRODUCT_VERSION='CentOS Stream'
++ echo centos
+ echo NAME=centos
++ . /tmp/kstest-iso.xWD61BR/os-release
+++ NAME='CentOS Stream'
+++ VERSION=10
+++ ID=centos
+++ ID_LIKE='rhel fedora'
+++ VERSION_ID=10
+++ PLATFORM_ID=platform:el10
+++ PRETTY_NAME='CentOS Stream 10'
+++ ANSI_COLOR='0;31'
+++ LOGO=fedora-logo-icon
+++ CPE_NAME=cpe:/o:centos:centos:10
+++ HOME_URL=https://centos.org/
+++ BUG_REPORT_URL=https://issues.redhat.com/
+++ REDHAT_SUPPORT_PRODUCT='Red Hat Enterprise Linux 10'
+++ REDHAT_SUPPORT_PRODUCT_VERSION='CentOS Stream'
++ echo 10
+ echo VERSION=10

rvykydal · 2024-05-16T08:09:17Z

/test-os-variants

rvykydal · 2024-05-16T08:20:40Z

The failure of rhel10 os-variant failed because the correct iso was not fetched (or rather the rawhide iso was used):

2024-05-16T07:15:10.7597148Z INFO:libpermian.plugins.kickstart_test(Thread-5):Created url overrides file /tmp/defaults-ai7sji6a with content:
2024-05-16T07:15:10.7598711Z export KSTEST_URL=https://composes.stream.centos.org/stream-10/development/latest-CentOS-Stream/compose/BaseOS/x86_64/os/
2024-05-16T07:15:10.7600470Z export KSTEST_MODULAR_URL=https://composes.stream.centos.org/stream-10/development/latest-CentOS-Stream/compose/AppStream/x86_64/os/
2024-05-16T07:15:10.7603613Z INFO:libpermian.plugins.kickstart_test(Thread-5):Using existing kickstart-tests repository /home/github/actions-runner/_work/kickstart-tests/kickstart-tests/kickstart-tests.
2024-05-16T07:15:10.7605510Z INFO:libpermian.plugins.kickstart_test(Thread-5):Fetchig installer boot.iso https://composes.stream.centos.org/stream-10/development/latest-CentOS-Stream/compose/BaseOS/x86_64/os/images/boot.iso
2024-05-16T07:15:10.7615949Z INFO:libpermian.plugins.kickstart_test(Thread-5):Runner is starting. SUCCESS: 0 FAILED: 0 N/A: 2 (runs: 0 flakes: 0 timed out: 0)
2024-05-16T07:15:10.7618145Z INFO:libpermian.plugins.kickstart_test(Thread-5):Running ['containers/runner/launch', '--scenario', 'run_subset', '--platform', 'rhel10', '--defaults', '/tmp/defaults-ai7sji6a', '--timeout', '0', 'ui_text_interactive', 'ui_graphical_interactive']
2024-05-16T07:15:10.7748712Z INFO:libpermian.plugins.kickstart_test(Thread-5):[runner] INFO: data/images/boot.iso does not exist, downloading current Fedora Rawhide Everything image...

This was caused by https missing here: https://github.com/rhinstaller/permian/blob/14b4f7dc2701110f8d8e49fd50e1b861d11b46f5/libpermian/plugins/kickstart_test/__init__.py#L308
Using http instead.

M4rtinK

Looks good to me, thanks!. :)

I'm thinking that ideally we should use Cent OS stream across the board in our CI infra. I would even suggest that if some differences are problematic (eq. Connect to Red HAt spoke not enabled) we might as well build our own "RHEL 10 like" isos from CentOS stream repos. That should also make it quicker to address any breakage with a hot fix.

rvykydal · 2024-05-16T08:26:05Z

Also the values for substitutions NAME="centos" (@KSTEST_OS_NAME@) in tested kickstart are not those that would be expected for rhel 10, for example here:

kickstart-tests/dns.ks.in

Line 16 in cdce5e6

if [ "@KSTEST_OS_NAME@" == "rhel" ]; then

+++ NAME='CentOS Stream'
+++ VERSION=10
+++ ID=centos
+++ ID_LIKE='rhel fedora'
+++ VERSION_ID=10
+++ PLATFORM_ID=platform:el10
+++ PRETTY_NAME='CentOS Stream 10'
+++ ANSI_COLOR='0;31'
+++ LOGO=fedora-logo-icon
+++ CPE_NAME=cpe:/o:centos:centos:10
+++ HOME_URL=https://centos.org/
+++ BUG_REPORT_URL=https://issues.redhat.com/
+++ REDHAT_SUPPORT_PRODUCT='Red Hat Enterprise Linux 10'
+++ REDHAT_SUPPORT_PRODUCT_VERSION='CentOS Stream'
++ echo centos
+ echo NAME=centos
++ . /tmp/kstest-iso.xWD61BR/os-release
+++ NAME='CentOS Stream'
+++ VERSION=10
+++ ID=centos
+++ ID_LIKE='rhel fedora'
+++ VERSION_ID=10
+++ PLATFORM_ID=platform:el10
+++ PRETTY_NAME='CentOS Stream 10'
+++ ANSI_COLOR='0;31'
+++ LOGO=fedora-logo-icon
+++ CPE_NAME=cpe:/o:centos:centos:10
+++ HOME_URL=https://centos.org/
+++ BUG_REPORT_URL=https://issues.redhat.com/
+++ REDHAT_SUPPORT_PRODUCT='Red Hat Enterprise Linux 10'
+++ REDHAT_SUPPORT_PRODUCT_VERSION='CentOS Stream'
++ echo 10
+ echo VERSION=10

The tests (roughly) that could be affected (definitely not all):

[rvykydal@prnot4 ~/work/git/rvykydal/kickstart-tests (use-centos10-iso-temporarily)]$ grep OS_NAME *.ks.in
anaconda-conf.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ || \
anaconda-conf.ks.in:   is_rhel9 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
anaconda-modules.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ || \
anaconda-modules.ks.in:   is_rhel9 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
autopart-nohome.ks.in:if [ "@KSTEST_OS_NAME@" == "fedora" ]; then
autopart-nohome.ks.in:if [ "@KSTEST_OS_NAME@" == "fedora" ]; then
bindtomac-bridge-2devs-httpks.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
bindtomac-bridge-2devs-pre.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
bindtomac-bridge-httpks.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
bond-ks-initramfs.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
bond-ks-initramfs.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
bridge-2devs-httpks.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
bridge-2devs.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
bridge-2devs-pre.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
bridge-httpks.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
bridge-no-bootopts-net.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
default-fstype.ks.in:if [ "@KSTEST_OS_NAME@" == "rhel" ] || grep -qi '^variant=server' /.buildstamp; then
dns.ks.in:if [ "@KSTEST_OS_NAME@" == "rhel" ]; then
network-addr-gen-mode.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
network-autoconnections-dhcpall-httpks.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
network-autoconnections-dhcpall-httpks.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
network-autoconnections-dhcpall-httpks.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
network-autoconnections-dhcpall-httpks.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
network-autoconnections-httpks.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
network-autoconnections-httpks.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
network-autoconnections-httpks.ks.in:    if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
network-autoconnections-httpks.ks.in:    if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
network-device-mac.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
network-options-pre.ks.in:if [ "@KSTEST_OS_NAME@" == "rhel" ]; then
repo-install.ks.in:if is_rhel8 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ || \
repo-install.ks.in:   is_rhel9 @KSTEST_OS_NAME@ @KSTEST_OS_VERSION@ ; then
reqpart.ks.in:if [ "@KSTEST_OS_NAME@" == "rhel" ] || grep -qi '^variant=server' /.buildstamp; then

We should replace these conditions and functions with platform(@KSTEST_OS_NAME@ @KSTEST_OS_VERSION@) function that would be also consistent with our fragments solution.

Use centos 10 in place of rhel 10 temporarily for rhel10 --platform

17e9ebd

rvykydal force-pushed the use-centos10-iso-temporarily branch from 8609da1 to 17e9ebd Compare May 16, 2024 08:08

M4rtinK approved these changes May 16, 2024

View reviewed changes

rvykydal merged commit 470818c into rhinstaller:master May 16, 2024
4 of 5 checks passed

rvykydal mentioned this pull request May 16, 2024

Consider centos os-variant as rhel platform #1174

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use centos 10 in place of rhel 10 temporarily for rhel10 --platform #1173

Use centos 10 in place of rhel 10 temporarily for rhel10 --platform #1173

rvykydal commented May 16, 2024 •

edited

Loading

rvykydal commented May 16, 2024

rvykydal commented May 16, 2024 •

edited

Loading

rvykydal commented May 16, 2024

rvykydal commented May 16, 2024

M4rtinK left a comment

rvykydal commented May 16, 2024 •

edited

Loading

Use centos 10 in place of rhel 10 temporarily for rhel10 --platform #1173

Use centos 10 in place of rhel 10 temporarily for rhel10 --platform #1173

Conversation

rvykydal commented May 16, 2024 • edited Loading

rvykydal commented May 16, 2024

rvykydal commented May 16, 2024 • edited Loading

rvykydal commented May 16, 2024

rvykydal commented May 16, 2024

M4rtinK left a comment

Choose a reason for hiding this comment

rvykydal commented May 16, 2024 • edited Loading

rvykydal commented May 16, 2024 •

edited

Loading

rvykydal commented May 16, 2024 •

edited

Loading

rvykydal commented May 16, 2024 •

edited

Loading