Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sshpass with except (gh#1109) #1168

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

marusak
Copy link
Contributor

@marusak marusak commented May 15, 2024

sshpass is not shipped in rhel10 thus use simple except script to interactively pass password into ssh.

sshpass is not shipped in rhel10 thus use simple except script to
interactively pass password into ssh.
@marusak marusak requested a review from rvykydal May 15, 2024 14:26
@KKoukiou
Copy link
Contributor

/test-os-variants

Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you.

@rvykydal
Copy link
Contributor

I think we can accept the /test-os-variants result. rhel10 failure is expected, daily-iso failure will be fixed by #1170 and I think rawhide pass should be enough.

@marusak marusak merged commit ae15200 into rhinstaller:master May 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants