Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce gating with static code checks #1150

Merged
merged 3 commits into from
May 15, 2024
Merged

Introduce gating with static code checks #1150

merged 3 commits into from
May 15, 2024

Conversation

KKoukiou
Copy link
Contributor

No description provided.

@jkonecny12
Copy link
Member

Our experience is better with pylint. Ruff is great because it's fast but pylint is able to found more usually.

@KKoukiou
Copy link
Contributor Author

Our experience is better with pylint. Ruff is great because it's fast but pylint is able to found more usually.

Happy to run both.

@rvykydal rvykydal requested review from rvykydal and removed request for rvykydal May 14, 2024 07:03
rvykydal
rvykydal approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@rvykydal rvykydal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be OK merging this and eventually opening a PR for using pylint that may or not replace this one.

@KKoukiou KKoukiou merged commit 38fd954 into rhinstaller:master May 15, 2024
4 checks passed
@KKoukiou KKoukiou deleted the static-code-checks branch May 15, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvykydal rvykydal rvykydal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KKoukiou @jkonecny12 @rvykydal