Enhance reading of the Live keyboard layouts #6220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
This is alternative solution to #6219 |
jkonecny12
force-pushed
the
main-raise-exception-on-usupported-live-layout
branch
from
0420c19 to
d91a45d
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
KKoukiou
reviewed
Feb 28, 2025
| @@ -0,0 +1,27 @@ | |||
| # | |||
There was a problem hiding this comment.
Can't we just reuse, KeyboardConfigurationError from pyanaconda/modules/common/errors/configuration.py?
Seems generic enough.
There was a problem hiding this comment.
What would be the benefit? Seems to me that more verbose is better isn't it?
There was a problem hiding this comment.
I see your point. Errors are not split by the modules as structures etc... In that case we can avoid creating the localization error python module.
jkonecny12
force-pushed
the
main-raise-exception-on-usupported-live-layout
branch
from
d91a45d to
b5132ed
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
jkonecny12
force-pushed
the
main-raise-exception-on-usupported-live-layout
branch
from
b5132ed to
c57a272
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
jkonecny12
force-pushed
the
main-raise-exception-on-usupported-live-layout
branch
from
c57a272 to
a17ce6a
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
UPDATE:
|
jkonecny12
force-pushed
the
main-raise-exception-on-usupported-live-layout
branch
from
a17ce6a to
a141aaf
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
|
/packit build |
KKoukiou
reviewed
Mar 4, 2025
| # be used in localed | ||
| if t[0] != "xkb": | ||
| raise KeyboardConfigurationError( | ||
| f"Live system has layout which can't be used by Anaconda - {t}" |
There was a problem hiding this comment.
Do you want to translate this one? I show it in the Web UI as you noticed.
We don't plan to extend Live specific keyboard configuration but rather we want to onboard everyone to localed which will be one single solution.
The Live system (Gnome Shell) supports ibus input methods which are not supported by Anaconda. Anaconda can't support ibus because vconsole nor localed supports this because they need to be usable in TTY environment. Related: rhbz#2348726
This API is added so that web UI is able to read keyboard layouts without storing them to the localization module. Related: rhbz#2348726
jkonecny12
force-pushed
the
main-raise-exception-on-usupported-live-layout
branch
from
a141aaf to
9427fd5
Compare
KKoukiou
approved these changes
Mar 4, 2025
|
/kickstart-test --waive ran already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is doing two parts:
Related: rhbz#2348726