Move hardcoded flatpak remote to configuration #5493
Conversation
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
jkonecny12
added
blocked
|
I'm setting blocked because I'm not able to find an ISO for SIlverblue so I'm not able to test this. |
| these Flatpaks are deployed and the remote was hardcoded to remote Fedora. This remote | ||
| is then used for updating the Flatpaks after installation. | ||
|
|
||
| After this change Flatpak remote could be set by ``flatpak_remote`` key in the configuration |
There was a problem hiding this comment.
| After this change Flatpak remote could be set by ``flatpak_remote`` key in the configuration | |
| After this change Flatpak remote can be set by ``flatpak_remote`` key in the configuration |
data/anaconda.conf
Outdated
| @@ -105,6 +105,13 @@ enable_closest_mirror = True | |||
| # | |||
| default_source = CLOSEST_MIRROR | |||
|
|
|||
| # Default remote source after deployment of local Flatpaks from the ISO. | |||
| # Only one value could be set. | |||
There was a problem hiding this comment.
| # Only one value could be set. | |
| # Only one value can be set. |
There was a problem hiding this comment.
Maybe we can allow more than one value here? It is valid to have multiple remotes enabled. But then of course we have the question about which one is the default one.
| def flatpak_remote(self): | ||
| """Default remote source after deployment of local Flatpaks from the ISO. | ||
|
|
||
| Only one value could be set. |
There was a problem hiding this comment.
| Only one value could be set. | |
| Only one value can be set. |
|
You can use https://pagure.io/workstation-ostree-config/blob/main/f/justfile#_211 to build an ISO. You need to build a classic ostree commit before: |
|
You can also download a nightly compose from https://openqa.fedoraproject.org/nightlies.html |
jkonecny12
force-pushed
the
master-move-flatpak-remote-to-config
branch
from
86d6d0a to
173bb4e
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
@travier thanks for review - resolved Also tested on latest Rawhide Silverblue image and it works good. This is ready for review and merge. |
|
/kickstart-test --testtype smoke |
jkonecny12
force-pushed
the
master-move-flatpak-remote-to-config
branch
from
173bb4e to
d7b37b9
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
| with pytest.raises(ValueError): | ||
| convert("test remote URL") | ||
|
|
||
| with pytest.raises(ValueError): |
There was a problem hiding this comment.
I dont understand what this second exception checking is offering compared to the one one line above.
Would be worthy to add some comment for the different test cases, so that people who are not that familiar (see me) can understand that faster.
There was a problem hiding this comment.
Makes sense now - thanks :)
Without this change Anaconda always set the remote after flatpak deployment to name: fedora remote: oci+https://registry.fedoraproject.org that worked until now. However, uBlue[1] want's to use Flathub registry as the remote source. To enable this we should move the flatpak remote from code to configuration files and they should create this configuration file during the ISO creation. Another use-case for this are ISO images for container based OSTree deployments. The tool to create an ISO could also enable user to set their own set of flatpaks from any remote source to the ISO image with installer for offline deployment and changing this configuration to set the correct remote after installation. [1]: https://universal-blue.org/
jkonecny12
force-pushed
the
master-move-flatpak-remote-to-config
branch
from
d7b37b9 to
23dae6f
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
|
/kickstart-test --testtype smoke |
|
Failed check is not related. Merging. |
|
I'm so happy this got merged. Will this feature be available in versions of Anaconda earlier than Fedora 41? We found a work around for creating our installer, but it would be awfully nice to remove that work around if we can just add a config option instead! |
Without this change Anaconda always set the remote after flatpak
deployment to
that worked until now. However, uBlue[1] want's to use Flathub registry as the remote source.
To enable this we should move the flatpak remote from code to configuration files and they should create this configuration file during the ISO creation.
Another use-case for this are ISO images for container based OSTree deployments. The tool to create an ISO could also enable user to set their own set of flatpaks from any remote source to the ISO image with installer for offline deployment and changing this configuration to set the correct remote after installation.
Please check that your PR follows these rules:
Code conventions. tl;dr: Follow PEP8, wrap at 100 chars, and provide docstrings.
Commit message conventions. tl;dr: Heading, empty line, longer explanations, all wrapped manually. If in doubt, write a longer commit message with more details.
Tests pass and cover your changes. You can run tests locally manually, or have them run as part of the PR. A team member will have to enable tests manually after inspecting the PR.
If you don't know how, ask us for help!
Release notes and docs if the PR adds something major or changes existing behavior.
If you don't know how, ask us for help!
Note: This is community contribution in my free time - not a team effort 😁