rpmostreepayload: Handle /var as a user-specified mountpoint #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: ostreedev/ostree#855 Basically, if `/var` is in the user specified mounts, don't override it with the "default ostree" `var`. This allows people to easily keep all of their local state (apart from `/etc`) in a single partition with potentially different quotas etc.
|
LGTM |
|
Jenkins, it's ok to test. |
|
Ignore the test result. They are failing because of new pylint on rawhide. |
jkonecny12
approved these changes
May 18, 2017
There was a problem hiding this comment.
From the code point of view it looks good to me. However it would be great if @rvykydal can look on this too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: ostreedev/ostree#855
Basically, if
/varis in the user specified mounts, don't overrideit with the "default ostree"
var.This allows people to easily keep all of their local state (apart from
/etc)in a single partition with potentially different quotas etc.