Skip to content

Commit

Permalink
pasta: Re-enable "Local forwarder, IPv4" test, accept NXDOMAIN as res…
Browse files Browse the repository at this point in the history
…ponse

This case is fixed by passt commit bad252687271 ("conf, udp: Allow
any loopback address to be used as resolver") and the fix is now
available in packages included by the CI images.

Note that, depending on the resolver on the host, we might get
1.0.0.127.in-addr.arpa resolved to localhost, or simply NXDOMAIN for
it: accept a failure on the nslookup command, as long as we have a
response for 1.0.0.127.in-addr.arpa in the output. If we have any
response, that means we could talk to the resolver.

Signed-off-by: Stefano Brivio <[email protected]>
  • Loading branch information
sbrivio-rh committed Mar 8, 2023
1 parent cc7a1e6 commit f928cf5
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions test/system/505-networking-pasta.bats
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ function teardown() {
@test "podman networking with pasta(1) - External resolver, IPv4" {
skip_if_no_ipv4 "IPv4 not routable on the host"

run_podman run --net=pasta $IMAGE nslookup 127.0.0.1 || :
run_podman '?' run --net=pasta $IMAGE nslookup 127.0.0.1

assert "$output" =~ "1.0.0.127.in-addr.arpa" \
"127.0.0.1 not resolved"
Expand All @@ -335,14 +335,12 @@ function teardown() {
}

@test "podman networking with pasta(1) - Local forwarder, IPv4" {
skip "FIXME: #17074: some pasta dns problem"
skip_if_no_ipv4 "IPv4 not routable on the host"

run_podman run --dns 198.51.100.1 \
--net=pasta:--dns-forward,198.51.100.1 $IMAGE nslookup 127.0.0.1
--net=pasta:--dns-forward,198.51.100.1 $IMAGE nslookup 127.0.0.1 || :

assert "$output" =~ "1.0.0.127.in-addr.arpa" \
"127.0.0.1 not resolved to 1.0.0.127.in-addr.arpa"
assert "$output" =~ "1.0.0.127.in-addr.arpa" "No answer from resolver"
}

@test "podman networking with pasta(1) - Local forwarder, IPv6" {
Expand Down

0 comments on commit f928cf5

Please sign in to comment.