Merge pull request containers#18774 from dgibson/bad-default-protocol

pasta: Correct handling of unknown protocols
rhatdan · Jun 5, 2023 · e143a0f · e143a0f
2 parents 18eb74f + cf9bc25
commit e143a0f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/libpod/networking_pasta_linux.go b/libpod/networking_pasta_linux.go
@@ -48,7 +48,7 @@ func (r *Runtime) setupPasta(ctr *Container, netns string) error {
 				cmdArgs = append(cmdArgs, "-t")
 			case "udp":
 				cmdArgs = append(cmdArgs, "-u")
-			case "default":
+			default:
 				return fmt.Errorf("can't forward protocol: %s", protocol)
 			}
 

diff --git a/test/system/505-networking-pasta.bats b/test/system/505-networking-pasta.bats
@@ -681,3 +681,11 @@ function teardown() {
     sleep 1
     ! ps -p $(cat "${pidfile}") && rm "${pidfile}"
 }
+
+### Options ####################################################################
+@test "podman networking with pasta(1) - Unsupported protocol in port forwarding" {
+    local port=$(random_free_port "" "" tcp)
+
+    run_podman 126 run --net=pasta -p "${port}:${port}/sctp" $IMAGE true
+    is "$output" "Error: .*can't forward protocol: sctp"
+}