Fix possible panic with podman build --iidfile

Make sure we check for errors before trying to write the iidfile. [NO TESTS NEEDED] Ref containers#9594 Signed-off-by: Paul Holzinger <[email protected]>
rhatdan · Mar 3, 2021 · 4eed89a · 4eed89a
1 parent aed632c
commit 4eed89a
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/cmd/podman/images/build.go b/cmd/podman/images/build.go
@@ -265,6 +265,9 @@ func build(cmd *cobra.Command, args []string) error {
 	}
 
 	report, err := registry.ImageEngine().Build(registry.GetContext(), containerFiles, *apiBuildOpts)
+	if err != nil {
+		return err
+	}
 
 	if cmd.Flag("iidfile").Changed {
 		f, err := os.Create(buildOpts.Iidfile)
@@ -276,7 +279,7 @@ func build(cmd *cobra.Command, args []string) error {
 		}
 	}
 
-	return err
+	return nil
 }
 
 // buildFlagsWrapperToOptions converts the local build flags to the build options used