Use HTTPProxy settings from containers.conf

This PR takes the settings from containers.conf and uses them. This works on the podman local but does not fix the issue for podman remote or for APIv2. We need a way to specify optionalbooleans when creating containers. Fixes: containers#8843 Signed-off-by: Daniel J Walsh <[email protected]>
rhatdan · Dec 28, 2020 · 3855293 · 3855293
1 parent 8f75ed9
commit 3855293
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/cmd/podman/common/create.go b/cmd/podman/common/create.go
@@ -336,7 +336,7 @@ func DefineCreateFlags(cmd *cobra.Command, cf *ContainerCLIOpts) {
 
 	createFlags.BoolVar(
 		&cf.HTTPProxy,
-		"http-proxy", true,
+		"http-proxy", containerConfig.Containers.HTTPProxy,
 		"Set proxy environment variables in the container based on the host proxy vars",
 	)