Return error on missing host-gateway IP

Signed-off-by: Gregor Eichelberger <[email protected]>
rhatdan · Jul 19, 2023 · 9d93afa · 9d93afa
1 parent 870255d
commit 9d93afa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/libnetwork/etchosts/hosts.go b/libnetwork/etchosts/hosts.go
@@ -246,6 +246,9 @@ func parseExtraHosts(extraHosts []string, hostContainersInternalIP string) (Host
 		}
 		ip := values[1]
 		if values[1] == HostGateway {
+			if hostContainersInternalIP == "" {
+				return nil, fmt.Errorf("unable to replace %q of host entry %q: host containers internal IP address is empty", HostGateway, entry)
+			}
 			ip = hostContainersInternalIP
 		}
 		e := HostEntry{IP: ip, Names: []string{values[0]}}

diff --git a/libnetwork/etchosts/hosts_test.go b/libnetwork/etchosts/hosts_test.go
@@ -274,6 +274,12 @@ func TestNew(t *testing.T) {
 			extraHosts:      []string{"name"},
 			wantErrString:   "unable to parse host entry \"name\": incorrect format",
 		},
+		{
+			name:            "invalid host-gateway",
+			baseFileContent: baseFileContent1Spaces,
+			extraHosts:      []string{"gatewayname:host-gateway"},
+			wantErrString:   "host containers internal IP address is empty",
+		},
 	}
 
 	for _, tt := range tests {