Skip to content

Commit

Permalink
Default sysctl to net.ipv4.ping_group_range=0 0
Browse files Browse the repository at this point in the history
Fixes: containers/podman#11062

Signed-off-by: Daniel J Walsh <[email protected]>
  • Loading branch information
rhatdan committed Oct 25, 2021
1 parent da56e47 commit 3decd15
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pkg/config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ var _ = Describe("Config", func() {
It("should succeed with default config", func() {
// Given
// When
defaultSysctls := []string{
"net.ipv4.ping_group_range=0 0",
"net.ipv6.conf.all.accept_dad=0",
}
defaultConfig, err := NewConfig("")

// Then
Expand All @@ -32,6 +36,7 @@ var _ = Describe("Config", func() {
path, err := defaultConfig.ImageCopyTmpDir()
gomega.Expect(err).To(gomega.BeNil())
gomega.Expect(path).To(gomega.BeEquivalentTo("/var/tmp"))
gomega.Expect(defaultConfig.Containers.DefaultSysctls).To(gomega.BeEquivalentTo(defaultSysctls))
})

It("should succeed with devices", func() {
Expand Down
1 change: 1 addition & 0 deletions pkg/config/containers.conf
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ default_capabilities = [
#
default_sysctls = [
"net.ipv4.ping_group_range=0 0",
"net.ipv6.conf.all.accept_dad=0",
]

# A list of ulimits to be set in containers by default, specified as
Expand Down

0 comments on commit 3decd15

Please sign in to comment.