-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Awake wav mic mute settings #91
Awake wav mic mute settings #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to be missing some commits? You add the settings but don't use them anywhere?!...
This PR just sets up the use of these two variables for use on the command line when running a wyoming-satellite. Once passed in, they are use accordingly from the MicSettings class. Where else are you expecting them to be used in the repo? |
You pass those two settings in the command line and they will be stored in the MicSettings class. However, you are not reading them anywhere, so, there are not being used. There's no action in the satellite to use them and mute the mic. |
mute_during_awake_wav is already used here:
seconds_to_mute_after_awake_wav is already used here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are absolutely right, sorry. As per the notes in the PR I was expecting this to be new parameters, I wasn't expecting it was just exposing exiting one which was hardcoded in the settings.
Thanks! |
Adds two new settings: