Support building shared library of ucd #1
Conversation
| @@ -44,7 +44,7 @@ | |||
| #define iswspace ucd_isspace | |||
| #define iswupper ucd_isupper | |||
| #define iswxdigit ucd_isxdigit | |||
| #define tolower ucd_tolower | |||
| #define toupper udc_toupper | |||
| // #define tolower ucd_tolower | |||
There was a problem hiding this comment.
If I don't uncomment them, it causes errors in my code since I am using std::tolower and std::toupper in my code.
There was a problem hiding this comment.
This symlink causes errors on Windows when invoking make install since windows does not support symlinks.
| @@ -20,7 +20,7 @@ | |||
| #define ENDIAN_H_COMPAT_SHIM | |||
| #pragma once | |||
|
|
|||
| #if __has_include_next(<endian.h>) | |||
| #if __has_include_next(<endian.h>) && !defined(__APPLE__) | |||
There was a problem hiding this comment.
Without !defined(__APPLE__) it causes errors for iOS.
|
Thanks! |
|
Hi 👋 this actually broke building rhaspy - see: mudler/LocalAI#1356 and rhasspy/piper#286 |
|
@csukuangfj @mudler after these PR the piper windows build with cmake is broken, reverting the PR I can build again. |
could you try rhasspy/piper-phonemize#21 |
|
Same error: LINK : fatal error LNK1181: cannot open input file '..\ucd-tools\Release\ucd.lib' |
Could you tell us what changes you have made to use that PR from Piper-phonemize? |
|
Sorry, |
|
I've set commit |
Also, support installing
ucdwhen invokingmake install.