rfct: /etc/login.defs
#91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actions-rs/toolchain is archived. Rust is currently installed on GitHub actions runners. So the action was replaced by using rustup to install a minimal profile. build and test staged were added. Updated all steps to the latest version
The format is so simple that a custom parser would be much safer and faster than using regex. The original also should have used `^` instead of `\n`. This is one of the steps towards removing regex as a dependecy for this project and replacing it with parsers for the specific file formats.
|
I would like to wait for #89 to be resolved before this gets merged |
Add support for a different location of `/etc/login.defs` file and override the assumed defaults if the file is not present.
|
Closes #89. @rharish101, this is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with
fakegreetBtw, regex should have used
(?m)^because the first line would not be captured by\nhttps://docs.rs/regex/1.11.0/regex/#grouping-and-flags