[Openjdk 3029] no singleton jdk required for openjdk-21 #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to be required to remove the system JDK, as pulled in by Maven, prior to the introduction of the maven-openjdk21 package. Test coverage exists in modules/jdk/tests/features/openjdk.feature Signed-off-by: Jonathan Dowland <[email protected]>
jerboaa
approved these changes
May 22, 2024
|
Since the source change is a one-liner, for clarity here's the impact it has on the generated Dockerfile @@ -283,22 +283,12 @@
###### /
###### END module 'jboss.container.java.s2i.bash:1.0'
-###### START module 'jboss.container.java.singleton-jdk:1.0'
-###### \
- # Copy 'jboss.container.java.singleton-jdk' module content
- COPY modules/jboss.container.java.singleton-jdk /tmp/scripts/jboss.container.java.singleton-jdk
- # Custom scripts from 'jboss.container.java.singleton-jdk' module
- USER root
- RUN [ "sh", "-x", "/tmp/scripts/jboss.container.java.singleton-jdk/configure.sh" ]
-###### /
-###### END module 'jboss.container.java.singleton-jdk:1.0'
-
###### START image 'ubi8/openjdk-21:1.19'
###### \
# Set 'ubi8/openjdk-21' image defined environment variablesAnd the code that isn't called anymore is https://github.com/jboss-container-images/openjdk/blob/ubi8/modules/singleton-jdk/configure.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be required to remove the system JDK, as pulled in by Maven, prior to the introduction of the maven-openjdk21 package.
Test coverage exists in modules/jdk/tests/features/openjdk.feature
https://issues.redhat.com/browse/OPENJDK-3029