Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GHA by various methods #418

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Fix GHA by various methods #418

merged 5 commits into from
Dec 4, 2023

Conversation

jmtd
Copy link
Member

@jmtd jmtd commented Nov 14, 2023 •
edited
Loading

Get the GHA CI lights green again.

  • For some reason the GHA environment is configured with some docker.io credentials (Perhaps this is to do with interacting with ghcr.io). s2i seems to query remote repositories even when it's not planning to pull an image. Explicitly removing these (via logging out) works around this
  • Various tests, for still-unknown reasons, freeze indefinitely when run in GHA. Referencing my fork of behave-test-steps makes use of my changes to "watchdog" some docker API calls via a sub-process and abort if it does not complete within a timeout period. (cekit always fetches the v1 branch of behave-test-steps, at least until --steps-ref ships). This changes those tests from freezing the whole run, to just failing those tests.
  • Some label tests fail as I updated them in a recent PR and didn't update the images to match. Add name and version labels to all images to get that one passing.
  • Finally, tag most of the s2i/maven/http proxy tests, as well as a "java perf dir owner" test "ignore", which means they're skipped entirely. These tests are still failing, but I would prefer to get the CI functioning again for all the other tests whilst I continue to investigate them.

@jmtd

This comment was marked as outdated.

Sign in to view
@jmtd jmtd changed the title WIP :GHA: move back to manual cekit install WIP: experimental commits to resolve GHA issues Nov 15, 2023
@jmtd

This comment was marked as outdated.

Sign in to view
@jmtd jmtd mentioned this pull request Nov 16, 2023
Merged
@jmtd jmtd force-pushed the gha-try-manual-cekit branch from c497b8b to 3c47f3e Compare November 29, 2023 10:54
@jmtd
Remove docker credentials prior to tests/s2i
53079f1 
s2i misbehaves if registry credentials are present: tries and fails to query
image metadata from docker.io before each build, etc. See:
openshift/source-to-image#1134

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd jmtd force-pushed the gha-try-manual-cekit branch from 91e721d to 53079f1 Compare November 30, 2023 11:16
jmtd added 2 commits November 30, 2023 13:03
@jmtd
Reference jmtd fork of behave-test-steps
b697b7d 
The jmtd fork of behave-test-steps has its v1 branch matching this
PR: cekit/behave-test-steps#50

This adds a multiprocess watchdog around invoking
`docker.APIClient.exec_inspect`, which will abort the current step
if that call has not returned within 30 seconds.

This means a lock-up during a step will cause that test to fail and
not the whole test run.

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd
[OPENJDK-2414] define name and version labels
168022e 
These shadow the values from our base image which are otherwise
misleading, and result in the test "Check that common labels are
correctly set" passing.

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd jmtd changed the title WIP: experimental commits to resolve GHA issues Fix GHA by various methods Nov 30, 2023
@jmtd jmtd force-pushed the gha-try-manual-cekit branch from b419efd to 168022e Compare November 30, 2023 14:33
jmtd added 2 commits December 4, 2023 13:29
@jmtd
Temporarily ignore java_s2i.feature tests
6d5b0e7 
These consistently fail on GHA which requires further analysis to
resolve. In the meantime we need a functioning CI.

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd
temporarily disable java perf dir test
cc10c06 
Presently failing on GHA for all of JDKs 11,16,21; passes
locally. We will investigate why in a separate issue, meanwhile
disable so we can run the remaining tests.

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd jmtd force-pushed the gha-try-manual-cekit branch from bc1c4b0 to cc10c06 Compare December 4, 2023 13:29
@jmtd jmtd mentioned this pull request Dec 4, 2023
Closed
@jmtd jmtd requested a review from jerboaa December 4, 2023 14:51
@jerboaa
Copy link
Contributor

jerboaa commented Dec 4, 2023

Nice work!

@jmtd jmtd merged commit 45dabef into rh-openjdk:ubi9 Dec 4, 2023
6 checks passed
@jmtd jmtd deleted the gha-try-manual-cekit branch December 4, 2023 15:42
@jerboaa jerboaa mentioned this pull request Dec 18, 2023
Merged
@jmtd jmtd mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerboaa jerboaa jerboaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmtd @jerboaa