WIP: Multicast poc #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgiorgetti
reviewed
Oct 2, 2019
| @@ -91,6 +94,7 @@ def is_done_sending(self): | |||
| Returns True if all expected messages have been sent or if sender has timed out. | |||
| :return: | |||
| """ | |||
| #???? | |||
There was a problem hiding this comment.
Is it a doubt or do you have concerns with the logic?
fgiorgetti
reviewed
Oct 2, 2019
| def _wait(receivers): | ||
| for r in receivers: | ||
| while not r.receiver: | ||
| time.sleep(1) |
There was a problem hiding this comment.
Not sure if a time.sleep here might cause issues to proton.
Maybe we can use some of the proton events to consider the receivers in the list as ready.
There was a problem hiding this comment.
will change this as you suggest
|
@nicob87 I have added a few comments, but overall looks good to me. Tomorrow I will run it and see how it works. Nice job! |
added 5 commits
October 2, 2019 11:33
this needs to be tested with psi topology
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a snippet for showing different testing posibilities.