Added test support for 5 battle configs #5914
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOn1ine
added
the
category: battle-tests
Bassoonian
reviewed
Dec 31, 2024
| SINGLE_BATTLE_TEST("Super Luck increases the critical hit ratio by 1 stage") | ||
| { | ||
| u32 genConfig = 0; | ||
| for (u32 j = GEN_2; j < GEN_LATEST + 1; j++) |
There was a problem hiding this comment.
Why do these for loops start at Gen 2 if Gen 1 configs exist?
There was a problem hiding this comment.
Hmm, right. I need to make Gen 1 crit mechanic tests. Time to hit the books! xD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
B_CRIT_CHANCEB_CRIT_MULTIPLIERB_PARALYSIS_SPEEDB_CONFUSION_SELF_DMG_CHANCEB_MULTI_HIT_CHANCEDiscord contact info
AsparagusEduardo