Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extrapolated Battle Arena's move Mind ratings #2339

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

Fixes #2321

Discord contact info

AsparagusEduardo#6051

@AsparagusEduardo AsparagusEduardo linked an issue Sep 21, 2022 that may be closed by this pull request
@AsparagusEduardo AsparagusEduardo added category: battle-mechanic Pertains to battle mechanics type: data Changes focus on data labels Sep 22, 2022
@ghoulslash
Copy link
Collaborator

This should not be a table imo. If One point is awarded if a move that deals damage is chosen for use, why not check IS_MOVE_STATUS? The exceptions such as protect moves can be handled as exceptions, e.g.

void BattleArena_AddMindPoints(u8 battler)
{
    s8 *mindPoints = gBattleStruct->arenaMindPoints;
      if (gBattleMoves[gCurrentMove].effect == EFFECT_PROTECT)
         mindPoints[battler]--;
      else if<other_exceptions>
      else if (!IS_MOVE_STATUS(gCurrentMove)
         mindPoints[battler]++;
}

@AsparagusEduardo
Copy link
Collaborator Author

Good point.

@AsparagusEduardo
Copy link
Collaborator Author

Reworked Mind Point assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: battle-mechanic Pertains to battle mechanics type: data Changes focus on data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reminder: Extrapolate sMindRatings
2 participants