Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to PR #468 (phenology status timers) #1

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

glemieux
Copy link

@glemieux glemieux commented Apr 15, 2019

Fixed a few typos and some artifacts where itrue was changed to 1. Refactored the cstatus and dstatus checks to use any for a few cases. There might be more we can change.

Fixes: PR NGEET#468

User interface changes?: No

Code review: Ryan Knox

Testing: none, not expected to compile

Description:

Collaborators:

@rgknox

Expectation of Answer Changes:

Should be B4B.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

Fixed a few typos and some artifacts where `itrue` was changed to 1.  Refactored the `cstatus` and `dstatus` checks to use any for a few cases.  There might be more we can change.

Fixes: PR NGEET#468

User interface changes?: No

Code review: Ryan Knox

Testing: none, not expected to compile
@rgknox rgknox merged commit e1d278f into rgknox:rgknox-fix-10day-phen Apr 16, 2019
rgknox pushed a commit that referenced this pull request Apr 17, 2020
…merged-rkfixes

conditioning age mortality rate and history output
rgknox pushed a commit that referenced this pull request Jun 22, 2020
merge medlyn changes up to master
rgknox pushed a commit that referenced this pull request Aug 5, 2020
update my fork with master
rgknox pushed a commit that referenced this pull request Oct 1, 2021
rgknox pushed a commit that referenced this pull request Jan 12, 2022
rgknox pushed a commit that referenced this pull request Mar 9, 2022
rgknox pushed a commit that referenced this pull request Jun 23, 2022
Bring fatesluc up to latest tag and deconflict
@glemieux glemieux deleted the rgknox-fix-10day-phen branch November 16, 2022 00:27
glemieux pushed a commit that referenced this pull request Nov 16, 2022
updates to live grass fire pools and other changes. Adding to original PR
rgknox pushed a commit that referenced this pull request Jul 18, 2023
…actor

Refactor `SeedlingParPatch` to avoid code duplication
rgknox pushed a commit that referenced this pull request Aug 14, 2024
remove damage and parameter changes, merge in main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants