dnsdist: No need to multiply 1.0 in cache-miss ratio dynblocks

As suggested by Charles-Henri, thanks!
rgacogne · Dec 11, 2023 · 28e9ac2 · 28e9ac2
1 parent 198e216
commit 28e9ac2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pdns/dnsdistdist/dnsdist-dynblocks.cc b/pdns/dnsdistdist/dnsdist-dynblocks.cc
@@ -949,7 +949,7 @@ bool DynBlockRulesGroup::DynBlockCacheMissRatioRule::checkGlobalCacheHitRatio()
   if (globalMisses == 0 || globalHits == 0) {
     return false;
   }
-  double globalCacheHitRatio = (static_cast<double>(globalHits) * static_cast<double>(1.0)) / static_cast<double>(globalHits + globalMisses);
+  double globalCacheHitRatio = static_cast<double>(globalHits) / static_cast<double>(globalHits + globalMisses);
   return globalCacheHitRatio >= d_minimumGlobalCacheHitRatio;
 }