Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Limit var definitions to root #16

Closed
wants to merge 1 commit into from
Closed

PR: Limit var definitions to root #16

wants to merge 1 commit into from

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Dec 17, 2013

Up for peer-review

Fix gh-15

@necolas necolas mentioned this pull request Dec 17, 2013
Closed
@ianstormtaylor
Copy link
Contributor

+1

@necolas
Copy link
Contributor Author

necolas commented Dec 17, 2013

This actually blows up if there's a media query in the CSS.

Limit var definitions to :root
44bb4c7 
* Only process and replace variables defined in `:root`.
* Make sure removal doesn't affect normal rules.
* Throw an error when variables are defined in @blocks like @media and
  @supports (needs more thought about how to support this use case).
@necolas
Copy link
Contributor Author

necolas commented Dec 18, 2013

Should be ok now. Will throw an error if vars are set in media queries, until we can decide what to do in #17

@necolas
Copy link
Contributor Author

necolas commented Dec 18, 2013

Fixed by 1ec1555

@necolas necolas closed this Dec 18, 2013
@MoOx MoOx deleted the limit-to-root branch June 21, 2014 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit var definitions to :root
2 participants
@necolas @ianstormtaylor