Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write out megastock table with sample size tag #31

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Write out megastock table with sample size tag #31

merged 5 commits into from
Feb 11, 2025

Conversation

mikivee
Copy link
Collaborator

@mikivee mikivee commented Feb 7, 2025 •
edited
Loading

  • Modified final script that writes out megastock table to have sample size in table name so that table in production does not get modified. Subsequent PR in dohyo will modify the code to point at a particular sample size table.
  • Cleaned up some old bugs

tarrenpeterson
tarrenpeterson approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@tarrenpeterson tarrenpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - sorry for the delay in reviewing!

@mikivee mikivee merged commit 0763726 into main Feb 11, 2025
2 checks passed
@mikivee mikivee deleted the mev/write_out_megastock_with_sample_size_tag branch February 11, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrenpeterson tarrenpeterson tarrenpeterson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikivee @tarrenpeterson