Fix upgrade feature bugs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrenpeterson
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a few bugs related to upgrade features and retraining (see job run). The downstream changes in the Dohyo Repo are made in this PR.
Results:
Results described here and the direct effect of the bugfix is show in the table below, where the Median APE is for savings for all upgrades except for baseline (upgrade 0), for which absolute consumption is shown. As expected, the improvement was fairly large for upgrades 6 and 9 which were directly effected, but the error decreased for all other upgrades as well because the incorrect feature coding misleading signals for all training data.
Notion Ticket: .