-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to disable drag and drop plugin #683
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe update refines the drag functionality within the grid’s overlay selection component. The drag state now requires both the component’s internal flag (this.canDrag) and the data flag (data.canDrag) to be true. This change, made in the grid component file, does not affect other parts of the code or the public entity declarations. Changes
Sequence Diagram(s)sequenceDiagram
participant Grid as RevoGridComponent
participant Overlay as revogr-overlay-selection
Grid->>Grid: Evaluate effectiveDrag = this.canDrag && data.canDrag
Grid->>Overlay: Render overlay with canDrag = effectiveDrag
Overlay-->>Grid: Render complete with updated drag behavior
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Improved drag hold
Summary by CodeRabbit