Plugin: add-rows-on-paste #599
Conversation
| const newRows = []; | ||
|
|
||
| for(let i = 0; i < count; i++) { | ||
| newRows.push({ index: rowLength + i, data: {} }); | ||
| } |
There was a problem hiding this comment.
This might be a handy shortcut
const newRows = Array.from({ length: count }, (_, i) => ({ index: rowLength + i, data: {} }))
There was a problem hiding this comment.
I believe loop works better and more efficient
| const items = this.providers.data.stores.rgRow.store.get('source'); | ||
|
|
||
| items.push(...event.detail.newRows.map(j => j.data)) | ||
|
|
||
|
|
||
| this.providers.data.setData(items); |
There was a problem hiding this comment.
Given that we'e doing a items.push() (mutates the items array) and then also calling setData(items), are we mutating the data source twice here?
Wondering if this might be better, or maybe it doesn't matter;
const items = [
...this.providers.data.stores.rgRow.store.get('source'),
...event.detail.newRows.map(j => j.data)
]
this.providers.data.setData(items);
|
@Techn1x How would you recommend adding columns as well? This might be more difficult because of the mapping from column to object property? |
Yeah you're totally right, didn't think of that. I think it's a fair assumption that columns are statically defined by the developr and won't change based on user pasting in data input |
I believe that's the point of open source so everyone reviews holds wait :-) |
|
|
Thank you @richardliebmann, all merged, probably we'll add some more updates on it in the future if you don't mind. |
|
Silly question but what path do I import this plugin from? There's docs on creating plugins but I am having trouble using 😄
EDIT: nevermind, it's simply from the main path. Just had to read the source code and see how it was all being exported |
This plugin adds new rows to the data if the number of entries is greater than the current data count.
Closes #338