Multi Filtering improvement to current filter plugin #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2a2x
reviewed
Mar 21, 2022
m2a2x
reviewed
Mar 21, 2022
m2a2x
reviewed
Mar 21, 2022
m2a2x
requested changes
Mar 21, 2022
…h first filter only
m2a2x
approved these changes
Mar 25, 2022
| this.addEventListener('headerclick', headerclick); | ||
| this.addEventListener('aftersourceset', aftersourceset); |
There was a problem hiding this comment.
why did you remove this?
it was supposed to filter when we apply new data source if we have any filter
| // check is filter event prevented | ||
| const { defaultPrevented, detail } = this.emit('beforefiltertrimmed', { collection, itemsToFilter, source: items }); |
There was a problem hiding this comment.
here you removed a way to override filter externally, when you removed details
src/plugins/filter/filter.plugin.tsx
Outdated
| continue; | ||
| } | ||
| propFilterSatisfiedCount++; | ||
| } else if (filterData.relation === 'and') { |
There was a problem hiding this comment.
do we need else if here? can't it be just else and so if no relation it'll be treated as and?
|
|
||
| const aftersourceset = async () => { | ||
| const filterCollectionProps = Object.keys(this.filterCollection); | ||
| if (filterCollectionProps.length > 0) { |
There was a problem hiding this comment.
can be just filterCollectionProps.length
src/plugins/filter/filter.plugin.tsx
Outdated
| if (filterCollectionProps.length > 0) { | ||
| // handle old way of filtering by reworking FilterCollection to new MultiFilterItem | ||
| // since id is generated locally, we don't want to conflict with other filters by starting at 0 | ||
| let filterIdStart = 1000; |
There was a problem hiding this comment.
better to make time based, 1000 seems just a random number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add multi filters to a column. can ba and or or relation or both.