Added waitForPageToLoad function #57
Conversation
Marketionist
changed the title
| @@ -1,4 +1,4 @@ | |||
| let e = {}; | |||
| const e = {}; | |||
There was a problem hiding this comment.
This object is being changed in the next line, so it looks like it should be let instead of const
| @@ -1,4 +1,4 @@ | |||
| let e = {}; | |||
| const e = {}; | |||
There was a problem hiding this comment.
This object is being changed (extended with additional properties) in the next 2 lines, so it looks like it should be let instead of const
src/helpers/objects.processor.js
Outdated
| @@ -64,7 +64,7 @@ function pageObjectGetter (str) { | |||
| function getPageObject (str) { | |||
| const pageObjectGetterFunc = stepsConfig.objectsProcessor.pageObjectGetter || pageObjectGetter; | |||
| const value = pageObjectGetterFunc(str); | |||
| const idValue = value.replace(_r(regDynamicId, 'g'), stepsConfig.id.getId()); | |||
| const idValue = value.replace(_r(regDynamicId, 'g'), stepsConfig.id.id); | |||
There was a problem hiding this comment.
stepsConfig.id.id - sounds a bit strange - maybe it will be better to name it stepsConfig.id.idValue?
src/helpers/objects.processor.js
Outdated
| @@ -99,7 +99,7 @@ function dictionaryGetter (str) { | |||
| function getDictionaryObject (str) { | |||
| const dictionaryGetterFunc = stepsConfig.objectsProcessor.dictionaryGetter || dictionaryGetter; | |||
| const value = dictionaryGetterFunc(str); | |||
| const idValue = value.replace(_r(regDynamicId, 'g'), stepsConfig.id.getId()); | |||
| const idValue = value.replace(_r(regDynamicId, 'g'), stepsConfig.id.id); | |||
There was a problem hiding this comment.
stepsConfig.id.id - sounds a bit strange - maybe it will be better to name it stepsConfig.id.idValue?
src/steps.conf.js
Outdated
| constructor () { | ||
| this.value = defaultIdValue || idGenerator.call(this); | ||
| } | ||
| get id () { |
There was a problem hiding this comment.
stepsConfig.id.id - sounds a bit strange - maybe it will be better to name it stepsConfig.id.idValue?
| @@ -1,4 +1,4 @@ | |||
| let e = {}; | |||
| const e = {}; | |||
There was a problem hiding this comment.
Maybe it is still better to use let here, because this object is being changed in the next line (adding property)?
| @@ -1,4 +1,4 @@ | |||
| let e = {}; | |||
| const e = {}; | |||
There was a problem hiding this comment.
Maybe it is still better to use let here, because this object is being changed in the next line (adding property)?
src/steps.conf.js
Outdated
| @@ -0,0 +1,36 @@ | |||
| const defaultFinishedLoadingConditions = (loaderSelectors) => { | |||
There was a problem hiding this comment.
Maybe we should rename this file to something like steps.helper.functions.js (because it looks more like a file with logic then config and we also have a second file with the same name in test/steps.conf.js - and it looks like a real config file more)?
src/steps.conf.generator.js
Outdated
| } | ||
|
|
||
| // Check if any loaders are still present on the page | ||
| return !loaderSelectors.some((selector) => browser.execute((s) => document.querySelector(s), selector)); |
There was a problem hiding this comment.
Maybe it will be better to use http://webdriver.io/api/protocol/executeAsync.html here as we are going to use async functions everywhere
…ervice: 0.0.10, webdriverio: ^4.12.0
This pull request adds waitForPageToLoad function
wdio.conf.jsto usesteps.conf.jsconstinstead ofletidentifier where possiblewaitForPageToLoaddoesn't workasyncbrowser.waitUntilfor waitForPageToLoadNOTE: WARNING: the "doDoubleClick" command will be deprecated soon. This command is not part of the W3C WebDriver spec and won't be supported in future versions of the driver. It is recommended to just call the click command on the same element twice in the row.
WARNING: the "moveTo" command will be deprecated soon. Note: This command is not part of the W3C WebDriver spec and won't be supported in future versions of the driver. It is recommended to use the actions command to emulate pointer events.