Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"I close current tab" and "I open new window" steps added #53

Merged
merged 2 commits into from
Mar 9, 2018

Conversation

robomanus
Copy link
Contributor

@robomanus robomanus commented Mar 6, 2018

"I close current tab" and "I open new window" steps added

Fix #29

@robomanus robomanus requested a review from Marketionist March 6, 2018 05:09
Copy link
Member

@Marketionist Marketionist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but please fix according to comment with And before the step

Then txtNewHeader from main page should be present
When I open new window
Then div from main page should not be present
When I close current tab
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is semantically more correct to use And here (as this is additional action)

@robomanus
Copy link
Contributor Author

I've updated step with 'And'

@Marketionist
Copy link
Member

LGTM

@robomanus robomanus merged commit 8ee55cb into master Mar 9, 2018
@robomanus robomanus deleted the feature/open-close-tabs branch March 9, 2018 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "I close current tab" and "I open new window" steps
2 participants